Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump avs version to 9.5.5 (WPB-5466) #2222

Merged
merged 2 commits into from
Nov 14, 2023
Merged

chore: bump avs version to 9.5.5 (WPB-5466) #2222

merged 2 commits into from
Nov 14, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 13, 2023 •
edited
Loading

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

This version fix performance and crop issues

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, alexandreferris, borichellow, MohamadJaara, vitorhugods and mchenani and removed request for a team November 13, 2023 16:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2023 •
edited
Loading

Unit Test Results

       6 files   - 466         6 suites   - 466   3m 33s ⏱️ +35s
2 509 tests  - 122  2 493 ✔️  -   34  16 💤  - 88  0 ❌ ±0 

Results for commit 7e30853. ± Comparison against base commit 83cdfef.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Nov 13, 2023 •
edited
Loading

Datadog Report

All test runs 33acc28 🔗

✅ 2 Total Test Services: 0 Failed, 0 with New Flaky, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Branch View
kalium-ios 0 0 0 2395 119 8m 53s Link
kalium-jvm 0 0 0 2527 104 15m 8.01s Link

@ohassine ohassine changed the title chore: bump avs version to 9.5.5 chore: bump avs version to 9.5.5 (WPB-5466) Nov 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2222 (7e30853) into develop (83cdfef) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             develop    #2222   +/-   ##
==========================================
  Coverage      58.07%   58.07%           
  Complexity        21       21           
==========================================
  Files           1073     1073           
  Lines          40749    40749           
  Branches        3778     3778           
==========================================
+ Hits           23663    23664    +1     
+ Misses         15466    15465    -1     
  Partials        1620     1620

see 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83cdfef...7e30853. Read the comment docs.

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 14, 2023
Merged via the queue into develop with commit 785e56e Nov 14, 2023
15 checks passed
@MohamadJaara MohamadJaara deleted the bump_avs branch November 14, 2023 13:49
MohamadJaara pushed a commit that referenced this pull request Nov 15, 2023
@ohassine @MohamadJaara
chore: bump avs version to 9.5.5 (#2222)
151eaee
MohamadJaara pushed a commit that referenced this pull request Nov 15, 2023
@ohassine @MohamadJaara
chore: bump avs version to 9.5.5 (#2222)
bb3579c
MohamadJaara added a commit that referenced this pull request Nov 16, 2023
@MohamadJaara @ohassine
chore: bump avs version to 9.5.5 (#2222) (#2227)
8fb8645 
Co-authored-by: Oussama Hassine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@alexandreferris alexandreferris alexandreferris approved these changes

@borichellow borichellow Awaiting requested review from borichellow borichellow was automatically assigned from wireapp/android

@vitorhugods vitorhugods Awaiting requested review from vitorhugods vitorhugods was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

Assignees

@ohassine ohassine

Labels
👕 size: XS type: chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ohassine @codecov-commenter @alexandreferris @MohamadJaara